Skip to content

fix(core): fail closed on git transport errors - #255

Merged
LeXwDeX merged 1 commit into
devfrom
fix/git-identity-errors
Aug 14, 2026
Merged

fix(core): fail closed on git transport errors#255
LeXwDeX merged 1 commit into
devfrom
fix/git-identity-errors

Conversation

@LeXwDeX

@LeXwDeX LeXwDeX commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • preserve normal Git non-zero exit semantics
  • fail closed when the Git process cannot start or transport fails
  • cover both repository discovery and root-commit lookup through ProjectV2.resolve

Verification

  • packages/core project + git tests: 16 passed
  • packages/core typecheck passed
  • mutation restoring the old catch makes both regression paths fail

Closes #239

@LeXwDeX
LeXwDeX merged commit dc69c45 into dev Aug 14, 2026
5 checks passed
@LeXwDeX
LeXwDeX deleted the fix/git-identity-errors branch August 14, 2026 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant